Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Clean up literal zero cuda_stream_view argument in get_json_object #7966

Closed
wants to merge 1 commit into from
Closed

[REVIEW] Clean up literal zero cuda_stream_view argument in get_json_object #7966

wants to merge 1 commit into from

Conversation

galipremsagar
Copy link
Contributor

Similar to this PR: #7774, we would have to update 0 literal with rmm::cuda_stream_default in get_json_object.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team libcudf blocker 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function labels Apr 15, 2021
@galipremsagar galipremsagar self-assigned this Apr 15, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner April 15, 2021 15:23
@galipremsagar galipremsagar requested a review from devavret April 15, 2021 15:23
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 15, 2021
@galipremsagar galipremsagar added non-breaking Non-breaking change breaking Breaking change and removed non-breaking Non-breaking change labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt Awaiting requested review from davidwendt

@devavret devavret Awaiting requested review from devavret

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@galipremsagar