-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete cudf::strings::replace_nulls #7965
Remove obsolete cudf::strings::replace_nulls #7965
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7965 +/- ##
===============================================
+ Coverage 82.30% 82.32% +0.02%
===============================================
Files 101 103 +2
Lines 17053 17374 +321
===============================================
+ Hits 14035 14303 +268
- Misses 3018 3071 +53
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gpucibot merge |
The
cudf::strings::replace_nulls()
is a public API that was replaced bycudf::replace_nulls()
.The strings one should not be used since the base one handles any column type.