Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete cudf::strings::replace_nulls #7965

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

davidwendt
Copy link
Contributor

The cudf::strings::replace_nulls() is a public API that was replaced by cudf::replace_nulls().
The strings one should not be used since the base one handles any column type.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress code quality libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function breaking Breaking change labels Apr 15, 2021
@davidwendt davidwendt self-assigned this Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #7965 (44ed039) into branch-0.20 (599f62d) will increase coverage by 0.02%.
The diff coverage is 92.08%.

❗ Current head 44ed039 differs from pull request most recent head cf2fb70. Consider uploading reports for the commit cf2fb70 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7965      +/-   ##
===============================================
+ Coverage        82.30%   82.32%   +0.02%     
===============================================
  Files              101      103       +2     
  Lines            17053    17374     +321     
===============================================
+ Hits             14035    14303     +268     
- Misses            3018     3071      +53     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <ø> (-6.45%) ⬇️
python/cudf/cudf/utils/utils.py 82.85% <ø> (-2.21%) ⬇️
python/cudf/cudf/core/column/lists.py 86.95% <80.00%> (-0.27%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 91.27% <80.95%> (-2.18%) ⬇️
python/cudf/cudf/core/column/struct.py 96.15% <86.66%> (-3.85%) ⬇️
python/cudf/cudf/core/index.py 92.58% <88.09%> (-0.44%) ⬇️
python/cudf/cudf/core/column/column.py 87.77% <88.57%> (+0.33%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 90.69% <92.30%> (+0.07%) ⬆️
python/cudf/cudf/core/join/join.py 96.72% <93.75%> (+0.20%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a666a0...cf2fb70. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 16, 2021
@davidwendt davidwendt marked this pull request as ready for review April 16, 2021 13:44
@davidwendt davidwendt requested a review from a team as a code owner April 16, 2021 13:44
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f11bcd7 into rapidsai:branch-0.20 Apr 21, 2021
@davidwendt davidwendt deleted the remove-replace-nulls branch April 21, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants