Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove cuda 10.x related files #7953

Merged
merged 9 commits into from
Apr 16, 2021
Merged

[REVIEW] Remove cuda 10.x related files #7953

merged 9 commits into from
Apr 16, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR removes cuda 10.x related files and updates the docker script(conda version) and its associated readme.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 14, 2021
@galipremsagar galipremsagar self-assigned this Apr 14, 2021
@galipremsagar galipremsagar requested review from a team as code owners April 14, 2021 02:19
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Apr 14, 2021
@galipremsagar galipremsagar added container Python Affects Python cuDF API. and removed conda Python Affects Python cuDF API. labels Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #7953 (d20b2b8) into branch-0.20 (599f62d) will increase coverage by 0.42%.
The diff coverage is 92.73%.

❗ Current head d20b2b8 differs from pull request most recent head a3e64ea. Consider uploading reports for the commit a3e64ea to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7953      +/-   ##
===============================================
+ Coverage        82.30%   82.72%   +0.42%     
===============================================
  Files              101      103       +2     
  Lines            17053    17714     +661     
===============================================
+ Hits             14035    14654     +619     
- Misses            3018     3060      +42
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <ø> (-6.45%) ⬇️
python/cudf/cudf/utils/utils.py 83.25% <ø> (-1.81%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <ø> (-0.05%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <78.57%> (-1.04%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <80.00%> (+0.19%) ⬆️
python/cudf/cudf/core/column/struct.py 96.29% <86.66%> (-3.71%) ⬇️
python/cudf/cudf/core/index.py 93.04% <88.09%> (+0.01%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <88.57%> (+0.43%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 91.11% <92.30%> (+0.48%) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9617fcd...a3e64ea. Read the comment docs.

kkraus14
kkraus14 reviewed Apr 14, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 14, 2021
@kkraus14
Copy link
Collaborator

rerun tests

karthikeyann
karthikeyann previously requested changes Apr 15, 2021
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

rerun tests

@kkraus14 kkraus14 dismissed karthikeyann’s stale review April 16, 2021 01:21

changes addressed

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4ad3d5d into rapidsai:branch-0.20 Apr 16, 2021
@codereport codereport mentioned this pull request Apr 21, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Apr 21, 2021
@codereport
Update ci/local/build.sh default $DOCKER_IMAGE (#8013)
5be3a62 
`DOCKER_IMAGE` is out of date since #7953 was merged. This fixes that.

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #8013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@mike-wendt mike-wendt mike-wendt approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

@karthikeyann karthikeyann Awaiting requested review from karthikeyann

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @kkraus14 @mike-wendt @karthikeyann @ajschmidt8