Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 10.2 workarounds in groupby functions for dictionary column types #7949

Merged

Conversation

davidwendt
Copy link
Contributor

Reference #7913
This removes the compiler restrictions in the libcudf groupby code that was disabled because of compiler issues on nvcc 10.2 when adding dictionary columns support. The corresponding disabled gtests have been enabled as well.

Details of the compiler bug are documented here: https://nvbugswb.nvidia.com/NvBugs5/SWBug.aspx?bugid=3186317

This also fixes an issue where the sum-of-squares aggregation was not working for values specified as a dictionary column.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 13, 2021
@davidwendt davidwendt self-assigned this Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #7949 (394e424) into branch-0.20 (51336df) will decrease coverage by 0.04%.
The diff coverage is 85.37%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7949      +/-   ##
===============================================
- Coverage        82.88%   82.84%   -0.05%     
===============================================
  Files              103      103              
  Lines            17668    17804     +136     
===============================================
+ Hits             14645    14750     +105     
- Misses            3023     3054      +31     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/io/orc.py 86.89% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 57.75% <25.00%> (ø)
python/cudf/cudf/utils/dtypes.py 81.87% <41.66%> (-1.57%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.43% <72.72%> (ø)
python/cudf/cudf/core/tools/datetimes.py 80.25% <74.69%> (-4.28%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 91.55% <76.92%> (+0.11%) ⬆️
python/cudf/cudf/core/column/column.py 88.64% <77.77%> (ø)
python/dask_cudf/dask_cudf/backends.py 89.51% <80.00%> (-0.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.83% <84.84%> (-2.09%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94afdda...394e424. Read the comment docs.

@davidwendt davidwendt marked this pull request as ready for review April 14, 2021 15:04
@davidwendt davidwendt requested a review from a team as a code owner April 14, 2021 15:04
@davidwendt
Copy link
Contributor Author

rerun tests

@karthikeyann
Copy link
Contributor

karthikeyann commented Apr 21, 2021

Creating separate functor for each operation for dicitonary keytype is repeating code and not scalable. It needs another refactor, may be in another PR. For removing 10.2 workarounds, this PR looks good.

@ttnghia
Copy link
Contributor

ttnghia commented Apr 26, 2021

Rerun tests.

@harrism
Copy link
Member

harrism commented Apr 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d08e041 into rapidsai:branch-0.20 Apr 27, 2021
@davidwendt davidwendt deleted the dictionary-enable-groupby-sum branch April 27, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants