-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 10.2 workarounds in groupby functions for dictionary column types #7949
Remove 10.2 workarounds in groupby functions for dictionary column types #7949
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7949 +/- ##
===============================================
- Coverage 82.88% 82.84% -0.05%
===============================================
Files 103 103
Lines 17668 17804 +136
===============================================
+ Hits 14645 14750 +105
- Misses 3023 3054 +31
Continue to review full report at Codecov.
|
rerun tests |
Creating separate functor for each operation for dicitonary keytype is repeating code and not scalable. It needs another refactor, may be in another PR. For removing 10.2 workarounds, this PR looks good. |
Rerun tests. |
@gpucibot merge |
Reference #7913
This removes the compiler restrictions in the libcudf groupby code that was disabled because of compiler issues on nvcc 10.2 when adding dictionary columns support. The corresponding disabled gtests have been enabled as well.
Details of the compiler bug are documented here: https://nvbugswb.nvidia.com/NvBugs5/SWBug.aspx?bugid=3186317
This also fixes an issue where the sum-of-squares aggregation was not working for values specified as a dictionary column.