-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add null order support to detail::drop_duplicates #7938
add null order support to detail::drop_duplicates #7938
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7938 +/- ##
===============================================
+ Coverage 82.30% 82.72% +0.42%
===============================================
Files 101 103 +2
Lines 17053 17714 +661
===============================================
+ Hits 14035 14654 +619
- Misses 3018 3060 +42
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is not updated yet for the additional parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I wonder if this |
@gpucibot merge |
Fixes #6144
Saves us a couple of kernel calls inside
cudf::encode
by ensuring nulls are always in the expected order.