Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add null order support to detail::drop_duplicates #7938

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 12, 2021

Fixes #6144

Saves us a couple of kernel calls inside cudf::encode by ensuring nulls are always in the expected order.

@cwharris cwharris added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 12, 2021
@cwharris cwharris requested a review from a team as a code owner April 12, 2021 19:33
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #7938 (84b0fc1) into branch-0.20 (599f62d) will increase coverage by 0.42%.
The diff coverage is 92.73%.

❗ Current head 84b0fc1 differs from pull request most recent head b0d2696. Consider uploading reports for the commit b0d2696 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7938      +/-   ##
===============================================
+ Coverage        82.30%   82.72%   +0.42%     
===============================================
  Files              101      103       +2     
  Lines            17053    17714     +661     
===============================================
+ Hits             14035    14654     +619     
- Misses            3018     3060      +42     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <ø> (-6.45%) ⬇️
python/cudf/cudf/utils/utils.py 83.25% <ø> (-1.81%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <ø> (-0.05%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <78.57%> (-1.04%) ⬇️
python/cudf/cudf/core/column/lists.py 87.41% <80.00%> (+0.19%) ⬆️
python/cudf/cudf/core/column/struct.py 96.29% <86.66%> (-3.71%) ⬇️
python/cudf/cudf/core/index.py 93.04% <88.09%> (+0.01%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <88.57%> (+0.43%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 91.11% <92.30%> (+0.48%) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 348ad4d...b0d2696. Read the comment docs.

Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is not updated yet for the additional parameter.

@cwharris cwharris requested a review from karthikeyann April 13, 2021 20:28
@cwharris cwharris requested a review from karthikeyann April 14, 2021 01:27
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ttnghia
Copy link
Contributor

ttnghia commented Apr 20, 2021

I wonder if this drop_duplicates API has any usage problem with NaN handling similar to lists::drop_list_duplicates?
Reference: #7662

@cwharris
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e018722 into rapidsai:branch-0.20 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add null_order parameter to cudf::detail::drop_duplicates
4 participants