-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove boost
dependency
#7932
Remove boost
dependency
#7932
Conversation
Can you remove boost from the conda recipes / environments / build instructions as well?
|
Boost is also installed in the docker_build Docker file Lines 43 to 45 in 7ad07b4
I'm not sure if the libboost-system-dev and libboost-regex-dev are needed for some other purpose.
|
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If LICENSE-bundled
is being deleted then the corresponding <resource>
node needs to be removed in java/pom.xml
rerun tests |
So it appears that gcc is not finding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake / conda lgtm
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7932 +/- ##
===============================================
- Coverage 82.88% 82.88% -0.01%
===============================================
Files 103 104 +1
Lines 17668 17907 +239
===============================================
+ Hits 14645 14843 +198
- Misses 3023 3064 +41
Continue to review full report at Codecov.
|
@gpucibot merge |
Once we remove Boost
filesystem
dependency and usestd::filesystem
, we can remove the boost dependency.This change requires dropping support for GCC < 9.