Code

Implement string list concatenation#7929

Code

Merged

rapids-bot[bot] merged 58 commits intorapidsai:branch-0.20rapidsai/cudf:branch-0.20from ttnghia:concat_wsttnghia/cudf:concat_wsCopy head branch name to clipboardApr 26, 2021

+1,095-106

Commits

Commits on Apr 7, 2021

• Re-organize function declarations, and add new declarations

  ttnghia

  committed
  7d4ac5a

• Add a skeleton implementation for the new concatenate APIs

  ttnghia

  committed
  da41c76

• Change docs

  ttnghia

  committed
  208dd51

• Add conditions for checking the parameter validity

  ttnghia

  committed
  ff6dc6d

Commits on Apr 8, 2021

• Rename variable

  ttnghia

  committed
  e43fe3f

• Implement a function that computes row size of the output strings column

  ttnghia

  committed
  51dcbdd

Commits on Apr 9, 2021

• Finish a draft for the concatenate API

  ttnghia

  committed
  94fd3ea

• Cleanup combine.cu

  ttnghia

  committed
  b4aa581

• Add one test for StringsListsConcatenateTest

  ttnghia

  committed
  465b821

• Merge remote-tracking branch 'origin/branch-0.20' into concat_ws

  ttnghia

  committed
  13a352a

• Finish ScalarSeparator test

  ttnghia

  committed
  a31e5f4

• Finish SlicedListsWithScalarSeparator test

  ttnghia

  committed
  4a46292

• Rewrite InvalidInput test

  ttnghia

  committed
  b61f384

• Rewrite EmptyInput, ZeroSizeStringsInput, and AllNullsStringsInput tests

  ttnghia

  committed
  0b56cdf

• Finish ColumnSeparators test

  ttnghia

  committed
  b3260ff

• Finish SlicedListsWithColumnSeparators test

  ttnghia

  committed
  c3b4ecc

• Rename variables

  ttnghia

  committed
  5b948a4

• Fix InvalidInput test

  ttnghia

  committed
  d1063a9

• Fix ZeroSizeStringsInput test

  ttnghia

  committed
  625407c

• Fix AllNullsStringsInput test

  ttnghia

  committed
  95dcdc2

• Implement string lists concatenation with scalar separator

  ttnghia

  committed
  5dc9fa4

• Cleanup string lists concatenation functions

  ttnghia

  committed
  ce6868f

• Fix output string size computation

  ttnghia

  committed
  227efde

• Fix child accessing for lists of strings column

  ttnghia

  committed
  584ea0f

• Fix slice indices for tests

  ttnghia

  committed
  4b235f5

• Fix tests for sliced input column

  ttnghia

  committed
  2e4e7b4

• Fix ClangFormat style

  ttnghia

  committed
  7c16e27

• Add comments

  ttnghia

  committed
  b67e20e

Commits on Apr 10, 2021

• Rename APIs

  ttnghia

  committed
  468a981

• Cleanup and fix ClangFormat style

  ttnghia

  committed
  4f65010

Commits on Apr 12, 2021

• Fix ClangFormat style

  ttnghia

  committed
  ebf2e03

Commits on Apr 20, 2021

• Merge remote-tracking branch 'origin/branch-0.20' into concat_ws

  Show description for 5f79043
  ttnghia

  committed
  5f79043

• Remove redundant headers

  ttnghia

  committed
  cd6eb88

• Resolve merge conflict with branch 0.20

  ttnghia

  committed
  3df31cd

• Add make_strings_children_with_null_mask utility function

  ttnghia

  committed
  d0eee9e

• Simplify code by using the new utility function make_strings_children_with_null_mask

  ttnghia

  committed
  a2496db

• Remove null_mask if the column does not have any null element

  ttnghia

  committed
  6715b1d

• Revert "Remove null_mask if the column does not have any null element"

  Show description for 17a3e9a
  ttnghia

  committed
  17a3e9a

• Fix string concatenation tests

  ttnghia

  committed
  097c788

• Fix the return null_mask: if null_count is 0 then return an empty buffer

  ttnghia

  committed
  391735f

• Re-organize code

  ttnghia

  committed
  3bdd92a

• Complete concatenate_list_elements

  ttnghia

  committed
  628e541

• Reorder cmake file list

  ttnghia

  committed
  ced89bc

• Update comments

  ttnghia

  committed
  aab44e0

• Update comment

  ttnghia

  committed
  2282010

• Reverse changes to concatenate.cu and reverse fixes for combine_tests.cpp

  ttnghia

  committed
  22cd1d3

• Fix ClangFormat style

  ttnghia

  committed
  3d03bee

Commits on Apr 21, 2021

• Extract strings/combine_tests.cpp into 3 separate cpp files

  ttnghia

  committed
  19a2819

• Use an additional array of int8_t type to store the validity of the strings; and use and additional boolean flag to specify which pass the kernel is executed

  ttnghia

  committed
  3cf2d10

• Avoid calling for_each_fn the second time if the output chars column has zero size

  ttnghia

  committed
  5fe852a

• Refactor functors to remove duplicate code

  ttnghia

  committed
  691cceb

• Fix ClangFormat style

  ttnghia

  committed
  d1931a4

• Rename variable

  ttnghia

  committed
  f883278

Commits on Apr 22, 2021

• Change the print parameter in unit tests

  ttnghia

  committed
  b33fd2a

• Rewrite comments, and remove thrust::uninitialized_fill for validities array

  ttnghia

  committed
  76ba7d1

• Fix copyright header and address review comments

  ttnghia

  committed
  647ca8f

Commits on Apr 23, 2021

• Add a parameter exec_size to allow executing the functor at a different range than the number of output strings

  ttnghia

  committed
  0e52459

• Minor improvement

  ttnghia

  committed
  cbee766