Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quantile for decimal columns #7927

Merged
merged 9 commits into from
Apr 21, 2021

Conversation

ChrisJar
Copy link
Contributor

@ChrisJar ChrisJar commented Apr 9, 2021

This enables the quantile method for columns of type decimal

@ChrisJar ChrisJar changed the title [WIPEnable quantile for decimal columns [WIP] Enable quantile for decimal columns Apr 9, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 9, 2021
@ChrisJar ChrisJar marked this pull request as ready for review April 20, 2021 03:45
@ChrisJar ChrisJar requested a review from a team as a code owner April 20, 2021 03:45
@ChrisJar ChrisJar changed the title [WIP] Enable quantile for decimal columns Enable quantile for decimal columns Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #7927 (763f1e0) into branch-0.20 (51336df) will decrease coverage by 0.36%.
The diff coverage is 86.86%.

❗ Current head 763f1e0 differs from pull request most recent head 8f0b933. Consider uploading reports for the commit 8f0b933 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7927      +/-   ##
===============================================
- Coverage        82.88%   82.52%   -0.37%     
===============================================
  Files              103      103              
  Lines            17668    17332     -336     
===============================================
- Hits             14645    14303     -342     
- Misses            3023     3029       +6     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/io/orc.py 86.80% <ø> (-0.10%) ⬇️
python/cudf/cudf/utils/cudautils.py 55.04% <25.00%> (-2.72%) ⬇️
python/cudf/cudf/utils/dtypes.py 83.22% <50.00%> (-0.22%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.41% <70.00%> (-0.02%) ⬇️
python/cudf/cudf/core/column/column.py 88.48% <75.00%> (-0.17%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.08% <78.26%> (-2.85%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.20% <80.00%> (-0.38%) ⬇️
python/cudf/cudf/core/dataframe.py 90.75% <83.33%> (-0.11%) ⬇️
python/cudf/cudf/utils/utils.py 89.94% <95.00%> (+0.43%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d501d2c...8f0b933. Read the comment docs.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 20, 2021
@galipremsagar
Copy link
Contributor

rerun tests

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 20, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit db30202 into rapidsai:branch-0.20 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants