Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scattering scalars into decimal columns #7899

Merged
merged 10 commits into from
Apr 16, 2021

Conversation

brandon-b-miller
Copy link
Contributor

@brandon-b-miller brandon-b-miller commented Apr 7, 2021

Closes #7879, adds the ability to coerce an int or Decimal to a different Decimal64Dtype where possible and begins to plumb pa.scalar into some useful places within cudf.Scalar

@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 7, 2021
@brandon-b-miller brandon-b-miller added 2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change labels Apr 14, 2021
@brandon-b-miller brandon-b-miller marked this pull request as ready for review April 14, 2021 22:16
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner April 14, 2021 22:16
@kkraus14
Copy link
Collaborator

rerun tests

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Apr 16, 2021
@kkraus14
Copy link
Collaborator

@brandon-b-miller is this ready to be merged? I noticed the PR description says draft at the bottom

@kkraus14 kkraus14 added 2 - In Progress Currently a work in progress and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #7899 (b77691f) into branch-0.20 (599f62d) will increase coverage by 0.02%.
The diff coverage is 92.16%.

❗ Current head b77691f differs from pull request most recent head 1d24130. Consider uploading reports for the commit 1d24130 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7899      +/-   ##
===============================================
+ Coverage        82.30%   82.32%   +0.02%     
===============================================
  Files              101      103       +2     
  Lines            17053    17373     +320     
===============================================
+ Hits             14035    14303     +268     
- Misses            3018     3070      +52     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <ø> (-6.45%) ⬇️
python/cudf/cudf/utils/utils.py 82.85% <ø> (-2.21%) ⬇️
python/cudf/cudf/core/column/lists.py 86.95% <80.00%> (-0.27%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 91.27% <80.95%> (-2.18%) ⬇️
python/cudf/cudf/core/column/struct.py 96.15% <86.66%> (-3.85%) ⬇️
python/cudf/cudf/core/index.py 92.58% <88.09%> (-0.44%) ⬇️
python/cudf/cudf/core/column/column.py 87.77% <88.57%> (+0.33%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 90.69% <92.30%> (+0.07%) ⬆️
python/cudf/cudf/core/join/join.py 96.72% <93.75%> (+0.20%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad07b4...1d24130. Read the comment docs.

@brandon-b-miller
Copy link
Contributor Author

@kkraus14 yup - all good here I believe.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Apr 16, 2021
@kkraus14
Copy link
Collaborator

rerun test

@brandon-b-miller
Copy link
Contributor Author

rerun tests

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bc422fc into rapidsai:branch-0.20 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support setting items in decimal colums
4 participants