Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GDS include path for version 0.95 #7877

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Apr 7, 2021

The GDS 0.95 release candidate moved the cufile.h file from the lib64 directory to the include directory under /usr/local/cuda. Added the new directory but also kept the old one so older versions of GDS can still be built.

@rongou rongou added 3 - Ready for Review Ready for review by team CMake CMake build issue 4 - Needs Review Waiting for reviewer to review or respond Spark Functionality that helps Spark RAPIDS improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2021
@rongou rongou requested a review from a team as a code owner April 7, 2021 00:22
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 7, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

cc @rapidsai/ops we'll likely want to update our build containers for this when we move to 0.95 as well

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #7877 (3eff1f7) into branch-0.19 (7871e7a) will increase coverage by 0.47%.
The diff coverage is n/a.

❗ Current head 3eff1f7 differs from pull request most recent head ce65abb. Consider uploading reports for the commit ce65abb to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7877      +/-   ##
===============================================
+ Coverage        81.86%   82.33%   +0.47%     
===============================================
  Files              101      103       +2     
  Lines            16884    17336     +452     
===============================================
+ Hits             13822    14274     +452     
  Misses            3062     3062              
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 86.95% <0.00%> (-4.45%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.25% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/utils/utils.py 85.06% <0.00%> (-0.38%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.28% <0.00%> (-0.35%) ⬇️
python/cudf/cudf/core/index.py 92.58% <0.00%> (-0.29%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e947c...ce65abb. Read the comment docs.

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

Pushing this to 0.20 but otherwise LGTM.

@kkraus14 kkraus14 changed the base branch from branch-0.19 to branch-0.20 April 7, 2021 17:15
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 7, 2021

@gpucibot merge

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Apr 7, 2021
@rongou
Copy link
Contributor Author

rongou commented Apr 7, 2021

rerun tests

@pxLi
Copy link
Member

pxLi commented Apr 8, 2021

@rongou I thought we would like to add this to 0.19 so plugin 0.5 could take this? Or we are targeting GDS support in plugin 1.0?

@rongou
Copy link
Contributor Author

rongou commented Apr 8, 2021

@kkraus14 is it possible to merge this into 0.19 so that we can include GDS 0.95 in the spark-rapids 0.5 release? Thanks!

@kkraus14 kkraus14 changed the base branch from branch-0.20 to branch-0.19 April 8, 2021 01:51
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 8, 2021

This change is minor and small and we're still debugging a Jitify2 issue so we can squeeze it in.

@rapids-bot rapids-bot bot merged commit 192ff46 into rapidsai:branch-0.19 Apr 8, 2021
@rongou rongou deleted the update-cufile-dir branch November 23, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants