Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf now sets an install rpath of $ORIGIN #7863

Merged

Conversation

robertmaynard
Copy link
Contributor

This corrects issues where a conda installed version of cudf can't find other conda installed libraries such as arrow.

This corrects issues where a conda installed version of cudf can't
find other conda installed libraries such as arrow.
@robertmaynard robertmaynard requested a review from a team as a code owner April 5, 2021 21:53
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 5, 2021
@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Apr 5, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 5, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #7863 (a9541fc) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

❗ Current head a9541fc differs from pull request most recent head 86150ea. Consider uploading reports for the commit 86150ea to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7863      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17700     +816     
===============================================
+ Hits             13822    14646     +824     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f1789...86150ea. Read the comment docs.

@rapids-bot rapids-bot bot merged commit b17ed17 into rapidsai:branch-0.19 Apr 6, 2021
@robertmaynard robertmaynard deleted the fix/bad_install_rpaths branch April 6, 2021 11:33
shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
This corrects issues where a conda installed version of cudf can't find other conda installed libraries such as arrow.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)

URL: rapidsai#7863
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Apr 8, 2021
Fix issue where conda installed `libcuspatial` can't find other conda-installed libraries like GDAL.

Related issue in cuDF: rapidsai/cudf#7863

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Christopher Harris (https://github.com/cwharris)
  - Keith Kraus (https://github.com/kkraus14)

URL: #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants