-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dask
+ distributed
to 2021.4.0
#7858
Conversation
cc @kkraus14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also open a PR against integration to update the versions there as well?
These versions appear to be already supported in the integration repo since they are above the minimums. Do we want to bump the minimums? https://github.com/rapidsai/integration/blob/9c8060e2c20219809591d200de706ef9225b4132/conda/recipes/versions.yaml#L49-L50 |
If you're bumping the minimums in cudf, then you should do the same in integration. |
With |
Sorry, just to clarify, whatever pinnings we use for dask/distributed in cudf should also be mirrored in integration. Whether its a minimum or maximum change, cudf and integration should mirror the pinnings. In addition, we should update other repos as well such as cuml |
cuML shouldn't be forced to follow cuDF's positioning on Dask / Distributed versioning. We need much more fine grained control over versioning in cuDF because dask.dataframe is often being changed alongside cuDF. cuML is generally using more general Dask APIs that don't have nearly the churn where they're safer to pin more loosely. If someone is only using cuML without dask-cudf this would unnecessarily constrain them. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7858 +/- ##
===============================================
+ Coverage 81.86% 82.74% +0.88%
===============================================
Files 101 103 +2
Lines 16884 17700 +816
===============================================
+ Hits 13822 14646 +824
+ Misses 3062 3054 -8
Continue to review full report at Codecov.
|
@gpucibot merge |
Needed to pick up some serialization bug fixes in the recent Distributed release ( dask/distributed#4645 ) ( dask/distributed#4662 ) Authors: - https://github.com/jakirkham Approvers: - Keith Kraus (https://github.com/kkraus14) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#7858
Needed to pick up some serialization bug fixes in the recent Distributed release ( dask/distributed#4645 ) ( dask/distributed#4662 )