Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dask + distributed to 2021.4.0 #7858

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

jakirkham
Copy link
Member

Needed to pick up some serialization bug fixes in the recent Distributed release ( dask/distributed#4645 ) ( dask/distributed#4662 )

@jakirkham jakirkham requested review from a team as code owners April 5, 2021 20:27
@jakirkham
Copy link
Member Author

cc @kkraus14

@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Apr 5, 2021
@jakirkham jakirkham added non-breaking Non-breaking change 3 - Ready for Review Ready for review by team dask Dask issue labels Apr 5, 2021
@kkraus14 kkraus14 added the improvement Improvement / enhancement to an existing function label Apr 5, 2021
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also open a PR against integration to update the versions there as well?

@jakirkham
Copy link
Member Author

@raydouglass
Copy link
Member

Do we want to bump the minimums?

If you're bumping the minimums in cudf, then you should do the same in integration.

@jakirkham
Copy link
Member Author

With distributed, we are bumping the maximum (not minimum). With dask, cuDF has adopted a tighter pinning policy. I'm not sure if we view these the same way as bumping minimums, but wanted to clarify in case something is getting lost here. Happy to do whatever we think is appropriate

@raydouglass
Copy link
Member

raydouglass commented Apr 5, 2021

Happy to do whatever we think is appropriate

Sorry, just to clarify, whatever pinnings we use for dask/distributed in cudf should also be mirrored in integration. Whether its a minimum or maximum change, cudf and integration should mirror the pinnings.

In addition, we should update other repos as well such as cuml

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 5, 2021

In addition, we should update other repos as well such as cuml

cuML shouldn't be forced to follow cuDF's positioning on Dask / Distributed versioning. We need much more fine grained control over versioning in cuDF because dask.dataframe is often being changed alongside cuDF. cuML is generally using more general Dask APIs that don't have nearly the churn where they're safer to pin more loosely.

If someone is only using cuML without dask-cudf this would unnecessarily constrain them.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #7858 (1de8011) into branch-0.19 (7871e7a) will increase coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7858      +/-   ##
===============================================
+ Coverage        81.86%   82.74%   +0.88%     
===============================================
  Files              101      103       +2     
  Lines            16884    17700     +816     
===============================================
+ Hits             13822    14646     +824     
+ Misses            3062     3054       -8     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.92% <0.00%> (-1.95%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f1789...1de8011. Read the comment docs.

@raydouglass
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 44e947c into rapidsai:branch-0.19 Apr 6, 2021
@jakirkham jakirkham deleted the update_dask_req branch April 6, 2021 16:20
shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
Needed to pick up some serialization bug fixes in the recent Distributed release ( dask/distributed#4645 ) ( dask/distributed#4662 )

Authors:
  - https://github.com/jakirkham

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#7858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants