Remove device_vectors from parquet
#7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devavret
added
non-breaking
|
Any benchmark results you can show to verify no regression? |
harrism
approved these changes
Apr 5, 2021
|
rerun tests |
vuule
approved these changes
Apr 5, 2021
| // TODO (dm): Enable dictionary for list after refactor | ||
| if (physical_type() != BOOLEAN && physical_type() != UNDEFINED_TYPE && !is_list()) { | ||
| alloc_dictionary(_data_count); | ||
| // TODO (dm): Enable dictionary for list and struct after refactor |
There was a problem hiding this comment.
Maybe file an issue (if you haven't already)?
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7853 +/- ##
===============================================
- Coverage 82.88% 82.51% -0.38%
===============================================
Files 103 103
Lines 17668 17296 -372
===============================================
- Hits 14645 14272 -373
- Misses 3023 3024 +1
Continue to review full report at Codecov.
|
hyperbolic2346
requested changes
Apr 6, 2021
No noticeable effect on benchmarks. Benchmark results
|
hyperbolic2346
approved these changes
Apr 6, 2021
vuule
added
5 - Merge After Dependencies
and removed
3 - Ready for Review
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 3, 2021
- Replaced raw pointers in parquet writer with appropriate spans - Used `hostdevice_2dvector` as approprate - Various parameter cleanups Depends on #7758 and #7853 Authors: - Devavret Makkar (https://github.com/devavret) - Mark Harris (https://github.com/harrism) Approvers: - Mike Wilson (https://github.com/hyperbolic2346) - Vukasin Milovanovic (https://github.com/vuule) URL: #7950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
device_vectorin favour of eitherdevice_uvectorordevice_bufferas appropriate in parquet reader and writer.Contributes to #7287
Depends on #7758