Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Revert dask versioning of concat dispatch #7823

Merged
merged 1 commit into from
Apr 2, 2021
Merged

[REVIEW] Revert dask versioning of concat dispatch #7823

merged 1 commit into from
Apr 2, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Apr 1, 2021 •
edited
Loading

Dependent on : dask/dask#7500

With the changes in above dask PR we would not have to version the concat dispatch in dask-cudf.

@galipremsagar galipremsagar self-assigned this Apr 1, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 1, 2021
@galipremsagar galipremsagar added 0 - Blocked Cannot progress due to external reasons dask Dask issue improvement Improvement / enhancement to an existing function and removed Python Affects Python cuDF API. labels Apr 1, 2021
@galipremsagar galipremsagar added the non-breaking Non-breaking change label Apr 1, 2021
@galipremsagar galipremsagar changed the title Revert dask versioning of concat dispatch [REVIEW] Revert dask versioning of concat dispatch Apr 1, 2021
@galipremsagar galipremsagar marked this pull request as ready for review April 1, 2021 21:11
@galipremsagar galipremsagar requested a review from a team as a code owner April 1, 2021 21:11
@galipremsagar galipremsagar requested a review from kkraus14 April 1, 2021 21:11
@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 1, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 0 - Blocked Cannot progress due to external reasons 5 - DO NOT MERGE Hold off on merging; see PR for details labels Apr 1, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #7823 (298e429) into branch-0.19 (7871e7a) will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7823      +/-   ##
===============================================
+ Coverage        81.86%   82.67%   +0.81%     
===============================================
  Files              101      103       +2     
  Lines            16884    17576     +692     
===============================================
+ Hits             13822    14531     +709     
+ Misses            3062     3045      -17
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.70% <0.00%> (-2.17%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/core/column/column.py 87.63% <0.00%> (-0.13%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <0.00%> (-0.05%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7153bb...298e429. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ee105fe into rapidsai:branch-0.19 Apr 2, 2021
@jakirkham
Copy link
Member

Thanks Prem! 😄

shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
@galipremsagar @shwina
Revert dask versioning of concat dispatch (rapidsai#7823)
5f4f7cc 
Dependent on : dask/dask#7500

With the changes in above dask PR we would not have to version the concat dispatch in `dask-cudf`.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - https://github.com/jakirkham

URL: rapidsai#7823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@kkraus14 kkraus14 Awaiting requested review from kkraus14

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @jakirkham