-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort by index in groupby tests more consistently #7802
Sort by index in groupby tests more consistently #7802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7802 +/- ##
===============================================
+ Coverage 81.86% 82.64% +0.78%
===============================================
Files 101 103 +2
Lines 16884 17566 +682
===============================================
+ Hits 13822 14518 +696
+ Misses 3062 3048 -14
Continue to review full report at Codecov.
|
…ix-groupby-tests-sort
@gpucibot merge |
rerun tests |
Pandas sorts the result of a groupby by its index by default, whereas we do not. For testing purposes, we currently call groupby() with
sort=True
in many of our tests. But some tests (notably newer ones) don't do that. These tests have been passing silently. Until now.assert_groupby_results_equal
helper intest_groupby.py
, which sorts its inputs by index before comparing themsort=True
we are doing in each of our groupby tests