Add decimal column handling in copy_type_metadata #7788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opy-decimal-type-metadata
There was a problem hiding this comment.
Thanks for this fix Ashwin 🙏
Can we now remove all explicit dtype checks too in the test_decimal file in this PR ? https://github.com/rapidsai/cudf/blob/branch-0.19/python/cudf/cudf/tests/test_decimal.py#L91
|
Will do! |
|
rerun tests |
galipremsagar
approved these changes
Mar 31, 2021
galipremsagar
added
the
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7788 +/- ##
===============================================
+ Coverage 82.26% 82.68% +0.41%
===============================================
Files 103 103
Lines 17201 17572 +371
===============================================
+ Hits 14151 14530 +379
+ Misses 3050 3042 -8
Continue to review full report at Codecov.
|
kkraus14
approved these changes
Mar 31, 2021
|
rerun tests |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2021
This enables joins on decimal columns with the same precision and scale. Closes #7497 Depends on #7788 Authors: - https://github.com/ChrisJar Approvers: - Keith Kraus (https://github.com/kkraus14) - Ashwin Srinath (https://github.com/shwina) - https://github.com/brandon-b-miller - Vyas Ramasubramani (https://github.com/vyasr) URL: #7764
shwina
pushed a commit
to shwina/cudf
that referenced
this pull request
Apr 7, 2021
This enables joins on decimal columns with the same precision and scale. Closes rapidsai#7497 Depends on rapidsai#7788 Authors: - https://github.com/ChrisJar Approvers: - Keith Kraus (https://github.com/kkraus14) - Ashwin Srinath (https://github.com/shwina) - https://github.com/brandon-b-miller - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#7764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All decimal columns returned by libcudf have a precision of 18 (
Decimal64Dtype.MAX_PRECISION). Thecopy_type_metadatamethod is extended to copy the precision from the input column to the result as often we want the returned column to have the same precision as the input column.In adding a test for this, I realized that the
assert_equtility is broken: it doesn't correctly check for dtype equality when the dtype is a cudf-specific type. Tacked on a fix.