Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add column names validation in parquet writer #7786

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #7738

Parquet writer requires all column names to be of string types, added a validation similar to that of pandas.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 31, 2021
@galipremsagar galipremsagar requested review from kkraus14 and vuule March 31, 2021 15:05
@galipremsagar galipremsagar self-assigned this Mar 31, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 31, 2021 15:05
@galipremsagar galipremsagar requested a review from isVoid March 31, 2021 15:05
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 31, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #7786 (9880b09) into branch-0.19 (7871e7a) will increase coverage by 0.82%.
The diff coverage is n/a.

❗ Current head 9880b09 differs from pull request most recent head 400883f. Consider uploading reports for the commit 400883f to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7786      +/-   ##
===============================================
+ Coverage        81.86%   82.69%   +0.82%     
===============================================
  Files              101      101              
  Lines            16884    17437     +553     
===============================================
+ Hits             13822    14419     +597     
+ Misses            3062     3018      -44     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/column/decimal.py 93.84% <0.00%> (-1.03%) ⬇️
python/cudf/cudf/core/column/column.py 87.53% <0.00%> (-0.23%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2f0c0...400883f. Read the comment docs.

@rapids-bot rapids-bot bot merged commit c05dbed into rapidsai:branch-0.19 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] be able to write parquet file for dataframe whose column names are not string
3 participants