-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Enable basic reductions for decimal columns #7776
Conversation
This should probably re-targeted 0.20? |
No this is planned for 0.19. |
Lots of things were planned for 0.19 that we would reject if the PR was opened during burndown... |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7776 +/- ##
===============================================
+ Coverage 81.86% 82.65% +0.78%
===============================================
Files 101 103 +2
Lines 16884 17578 +694
===============================================
+ Hits 13822 14529 +707
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@gpucibot merge |
Enables
sum
,min
,max
,product
, andsum_of_squares
forDecimalColumn
Closes #7683