Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Enable basic reductions for decimal columns #7776

Merged
merged 5 commits into from
Apr 1, 2021

Conversation

ChrisJar
Copy link
Contributor

@ChrisJar ChrisJar commented Mar 31, 2021

Enables sum, min, max, product, and sum_of_squares for DecimalColumn

Closes #7683

@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 31, 2021
@davidwendt
Copy link
Contributor

This should probably re-targeted 0.20?
@kkraus14

@kkraus14
Copy link
Collaborator

This should probably re-targeted 0.20?
@kkraus14

No this is planned for 0.19.

@kkraus14 kkraus14 added feature request New feature or request non-breaking Non-breaking change labels Mar 31, 2021
@ChrisJar ChrisJar changed the title [WIP] Enable basic reductions for decimal columns [REVIEW] Enable basic reductions for decimal columns Apr 1, 2021
@ChrisJar ChrisJar marked this pull request as ready for review April 1, 2021 00:16
@ChrisJar ChrisJar requested a review from a team as a code owner April 1, 2021 00:16
@harrism
Copy link
Member

harrism commented Apr 1, 2021

Lots of things were planned for 0.19 that we would reject if the PR was opened during burndown...

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #7776 (85dbadd) into branch-0.19 (7871e7a) will increase coverage by 0.78%.
The diff coverage is n/a.

❗ Current head 85dbadd differs from pull request most recent head d31535b. Consider uploading reports for the commit d31535b to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7776      +/-   ##
===============================================
+ Coverage        81.86%   82.65%   +0.78%     
===============================================
  Files              101      103       +2     
  Lines            16884    17578     +694     
===============================================
+ Hits             13822    14529     +707     
+ Misses            3062     3049      -13     
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.55% <0.00%> (-2.32%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/core/column/column.py 87.61% <0.00%> (-0.15%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e379ab1...d31535b. Read the comment docs.

@ChrisJar ChrisJar requested a review from isVoid April 1, 2021 17:14
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 1, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4f30fcd into rapidsai:branch-0.19 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support aggregates on Decimal columns in cudf Python
6 participants