Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StructMethods.field() API to access field of struct column #7757

Merged
merged 6 commits into from
Apr 6, 2021
Merged

Add StructMethods.field() API to access field of struct column #7757

merged 6 commits into from
Apr 6, 2021

Conversation

skirui-source
Copy link
Contributor

fixes: #7608

@skirui-source skirui-source added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. Cython labels Mar 30, 2021
@skirui-source skirui-source self-assigned this Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #7757 (369461c) into branch-0.20 (599f62d) will increase coverage by 0.44%.
The diff coverage is 87.66%.

❗ Current head 369461c differs from pull request most recent head 57713bc. Consider uploading reports for the commit 57713bc to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7757      +/-   ##
===============================================
+ Coverage        82.30%   82.74%   +0.44%     
===============================================
  Files              101      103       +2     
  Lines            17053    17720     +667     
===============================================
+ Hits             14035    14662     +627     
- Misses            3018     3058      +40
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <46.66%> (-6.45%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <75.00%> (+0.10%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 92.41% <78.57%> (-1.04%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.58% <85.71%> (-0.05%) ⬇️
python/cudf/cudf/core/column/struct.py 96.29% <86.66%> (-3.71%) ⬇️
python/cudf/cudf/core/index.py 93.04% <88.09%> (+0.01%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.92% <91.48%> (-0.92%) ⬇️
python/cudf/cudf/core/column/interval.py 91.11% <92.30%> (+0.48%) ⬆️
python/cudf/cudf/core/column/column.py 87.99% <92.59%> (+0.56%) ⬆️
python/cudf/cudf/core/join/join.py 96.75% <93.75%> (+0.24%) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f621a3...57713bc. Read the comment docs.

@shwina
Copy link
Contributor

shwina commented Mar 31, 2021

@skirui-source - we should probably rename this PR to match the new scope of changes; perhaps something like "Add StructMethods.field() API to access field of struct column"?

@skirui-source skirui-source changed the title Add Python API for column_view::child Add StructMethods.field() API to access field of struct column Mar 31, 2021
@kkraus14 kkraus14 changed the base branch from branch-0.19 to branch-0.20 March 31, 2021 21:46
@kkraus14
Copy link
Collaborator

Moved to 0.20.

@skirui-source skirui-source marked this pull request as ready for review April 1, 2021 02:42
@skirui-source skirui-source requested a review from a team as a code owner April 1, 2021 02:42
@skirui-source skirui-source requested a review from kkraus14 April 1, 2021 02:42
@skirui-source skirui-source added 3 - Ready for Review Ready for review by team breaking Breaking change and removed 2 - In Progress Currently a work in progress labels Apr 1, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 5, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 49d9e87 into rapidsai:branch-0.20 Apr 6, 2021
@kkraus14 kkraus14 added non-breaking Non-breaking change and removed breaking Breaking change labels Apr 6, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 6, 2021

This was not breaking so relabeled as such.

shwina pushed a commit to shwina/cudf that referenced this pull request Apr 7, 2021
@skirui-source @shwina
Add StructMethods.field() API to access field of struct column (rap…
2c7723c 
…idsai#7757)

fixes: rapidsai#7608

Authors:
  - https://github.com/skirui-source

Approvers:
  - Keith Kraus (https://github.com/kkraus14)

URL: rapidsai#7757
@skirui-source skirui-source deleted the columnview branch May 6, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina Awaiting requested review from shwina

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@skirui-source skirui-source

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Python bindings for column_view::child
3 participants
@skirui-source @shwina @kkraus14