-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slicing and arrow representations of decimal columns #7755
Fix slicing and arrow representations of decimal columns #7755
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7755 +/- ##
===============================================
+ Coverage 81.86% 82.67% +0.80%
===============================================
Files 101 103 +2
Lines 16884 17548 +664
===============================================
+ Hits 13822 14507 +685
+ Misses 3062 3041 -21
Continue to review full report at Codecov.
|
Looks good - there's some tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple quick test cases and this should be good to go.
@gpucibot merge |
Slices of decimal columns were not passing the appropriate offset to the new column views being created. Additionally, the conversion of decimal columns to and from arrow did not include the offset. This made all slices of decimal columns appear invalid.
Thanks to @shwina for helping me trace these bugs back to their source!
Edit
This PR also now includes an additional fix for the behavior of slices of decimal columns that should generate empty data sets (e.g. starting a slice past the end of a column).