Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable column_view data accessors for unsupported types #7725
Disable column_view data accessors for unsupported types #7725
Changes from 34 commits
d73219e
2f8e0dc
759bf6d
3df7685
c2604cb
5e6311c
5f818ad
55ff95b
24d437f
608459f
1453153
f99318e
a4788a0
95d55ea
98072b0
0238112
978af0b
9516e09
fb27cf1
400dbaf
dcd75e2
1134362
86437a6
7b7beae
daf2e72
160a660
fd24294
7d61ace
1d475e7
7c279ac
dc70ba6
9a9b0bc
3d08a57
e896a26
3a6405d
5982248
d6ce9f0
7e9abd4
6a56c02
d20e9ae
a057e71
85c8c11
f92d462
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Aren't we enforcing angle brackets
<>
for includes that aren't in the current directory?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, something in my vscode auto includes headers and uses
"
instead of<>
. I'll need to see if I can change that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clangd IWYU.