Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Expose libcudf's label_bins function to cudf #7724

Merged
merged 80 commits into from
Mar 26, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 25, 2021

This PR is a follow-up to #7554 and exposes the feature implemented there via Cython for consumption in cudf's Python API.

vyasr added 30 commits March 5, 2021 10:32
@vyasr vyasr requested a review from a team as a code owner March 25, 2021 16:08
@vyasr vyasr requested review from cwharris and rgsl888prabhu March 25, 2021 16:08
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 25, 2021
@vyasr vyasr added 3 - Ready for Review Ready for review by team Cython non-breaking Non-breaking change labels Mar 25, 2021
@vyasr vyasr added the feature request New feature or request label Mar 25, 2021
@vyasr vyasr requested a review from kkraus14 March 25, 2021 23:05
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #7724 (f2ddb19) into branch-0.19 (7871e7a) will increase coverage by 0.63%.
The diff coverage is n/a.

❗ Current head f2ddb19 differs from pull request most recent head 251b6c5. Consider uploading reports for the commit 251b6c5 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7724      +/-   ##
===============================================
+ Coverage        81.86%   82.49%   +0.63%     
===============================================
  Files              101      101              
  Lines            16884    17458     +574     
===============================================
+ Hits             13822    14402     +580     
+ Misses            3062     3056       -6     
Impacted Files Coverage Δ
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 87.68% <0.00%> (-3.72%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.95% <0.00%> (-1.92%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.83% <0.00%> (-0.20%) ⬇️
python/cudf/cudf/core/column/column.py 87.61% <0.00%> (-0.15%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1bd66...251b6c5. Read the comment docs.

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2693e0 into rapidsai:branch-0.19 Mar 26, 2021
@vyasr vyasr deleted the feature/cudf_expose_bin branch January 14, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants