-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory map the input file only when GDS compatiblity mode is not used #7717
Memory map the input file only when GDS compatiblity mode is not used #7717
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7717 +/- ##
===============================================
+ Coverage 81.86% 82.52% +0.65%
===============================================
Files 101 101
Lines 16884 17458 +574
===============================================
+ Hits 13822 14407 +585
+ Misses 3062 3051 -11
Continue to review full report at Codecov.
|
@gpucibot merge |
mmap
is expensive on some systems and we can expect better performance with file reads when GDS is used, especially with compatibility mode.This PR adds a source type that does not use
mmap
for host reads. This type is used when GDS and its compatibility mode are enabled.file_source
is now a base class for file-based input and only implements the device_read functions.memory_mapped_source
class implements the host reads through the memory mapped file.direct_read_source
is a newly implemented class that uses read for host reads, nommap
.Selection is done in
datasource::create
based oncufile_config
.