Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds list.unique API #7664

Merged
merged 14 commits into from
Mar 31, 2021
Merged

Adds list.unique API #7664

merged 14 commits into from
Mar 31, 2021

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 22, 2021

Closes #7414

This PR adds list.unique API. Following Series.unique behavior, this API treats null values as equal, and treats all nans as equal. This API does not guarantee the order of list elements. Example:

>>> s = cudf.Series([[1, 1, 2, None, None], None, [np.nan, np.nan], []])
>>> s.list.unique() # Order of list elements is not gaurenteed
0              [1.0, 2.0, nan]
1                         None
2                        [nan]
3                           []
dtype: list

@isVoid isVoid self-assigned this Mar 22, 2021
@isVoid isVoid added the 2 - In Progress Currently a work in progress label Mar 22, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 22, 2021
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Mar 22, 2021
python/cudf/cudf/core/column/lists.py Outdated Show resolved Hide resolved
@isVoid isVoid marked this pull request as ready for review March 30, 2021 22:11
@isVoid isVoid requested a review from a team as a code owner March 30, 2021 22:11
@isVoid isVoid added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 30, 2021
@isVoid isVoid requested review from kkraus14 and ttnghia March 30, 2021 22:15
@kkraus14 kkraus14 dismissed ttnghia’s stale review March 30, 2021 22:30

Stale review

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge 5 - Merge After Dependencies and removed 3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge labels Mar 30, 2021
@isVoid
Copy link
Contributor Author

isVoid commented Mar 31, 2021

rerun tests

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #7664 (c2b113d) into branch-0.19 (7871e7a) will increase coverage by 0.80%.
The diff coverage is n/a.

❗ Current head c2b113d differs from pull request most recent head 59d2cd9. Consider uploading reports for the commit 59d2cd9 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7664      +/-   ##
===============================================
+ Coverage        81.86%   82.67%   +0.80%     
===============================================
  Files              101      101              
  Lines            16884    17434     +550     
===============================================
+ Hits             13822    14413     +591     
+ Misses            3062     3021      -41     
Impacted Files Coverage Δ
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/core/column/decimal.py 93.84% <0.00%> (-1.03%) ⬇️
python/cudf/cudf/core/column/column.py 87.53% <0.00%> (-0.23%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd11dbe...59d2cd9. Read the comment docs.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - Merge After Dependencies labels Mar 31, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f285302 into rapidsai:branch-0.19 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add Python bindings for drop_list_duplicates
3 participants