Fix Java Parquet write after writer API changes [skip ci] #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
bug
jlowe
approved these changes
Mar 19, 2021
razajafri
reviewed
Mar 19, 2021
| */ | ||
| public Builder withPrecisionValues(int... precisionValues) { | ||
| public Builder withDecimalPrecisions(int ... precisionValues) { |
There was a problem hiding this comment.
nit: int ... => int...
extra space after int
razajafri
approved these changes
Mar 19, 2021
jlowe
changed the title
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the java build, but it required breaking changes to do it. I'll put up a corresponding change in the rapids plugin shortly.
#7654
was found as a part of this.
This is also not the final API that we will want. We need to redo how we configure the builders so that they can take advantage of the new APIs properly.