-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for cudf::strings::translate function #7617
Add gbenchmark for cudf::strings::translate function #7617
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7617 +/- ##
===============================================
+ Coverage 81.86% 82.44% +0.58%
===============================================
Files 101 101
Lines 16884 17369 +485
===============================================
+ Hits 13822 14320 +498
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
rerun tests |
@gpucibot merge |
Reference #5698
This creates a gbenchmark for the
cudf::strings::translate()
API. The benchmarks measures various sized rows as well as strings lengths and translate table sizes.This PR also includes changes to
translate.cu
implementation cleaning up the code and using the more efficient make_strings_children. This change improved performance for all 4 functions on average by 2-3x.A further improvement was to sort the translation table input to more quickly lookup matches in device code. This added another 2x improvement when using longer translate tables.