Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explode API #7606

Closed
wants to merge 23 commits into from
Closed

Add explode API #7606

wants to merge 23 commits into from

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 16, 2021 •
edited
Loading

Commit history issues, moved to 7607

hyperbolic2346 and others added 23 commits March 3, 2021 06:00
@hyperbolic2346
First pass at explode_outer and explode_outer_position
9541e27
@hyperbolic2346
Merge remote-tracking branch 'upstream/branch-0.19' into mwilson/expl…
566a8d1 
…ode_outer
@hyperbolic2346
merging two for_each calls into one
557fcfc
@hyperbolic2346
linting
7bcede0
@hyperbolic2346
Merge remote-tracking branch 'upstream/branch-0.19' into mwilson/expl…
869c27c 
…ode_outer
@hyperbolic2346
Merge remote-tracking branch 'upstream/branch-0.19' into mwilson/expl…
552e43c 
…ode_outer
@hyperbolic2346
Merge remote-tracking branch 'upstream/branch-0.19' into mwilson/expl…
23f4abc 
…ode_outer
@firestarman
Add Python bindings for explode
f3aa7b2 
since native already supports this feature over a table.

Signed-off-by: Firestarman <[email protected]>
@firestarman
use self instead of class name
0662ac6 
Signed-off-by: Firestarman <[email protected]>
@hyperbolic2346
Merge remote-tracking branch 'upstream/branch-0.19' into mwilson/expl…
01cdde2 
…ode_outer
@hyperbolic2346 @jrhemstad
Update cpp/src/reshape/explode.cu
4aee4ea 
Co-authored-by: Jake Hemstad <[email protected]>
@hyperbolic2346 @jrhemstad
Update cpp/src/reshape/explode.cu
b573889 
Co-authored-by: Jake Hemstad <[email protected]>
@hyperbolic2346 @jrhemstad
Update cpp/src/reshape/explode.cu
fb54f2e 
Co-authored-by: Jake Hemstad <[email protected]>
@hyperbolic2346
Updates based on review comments
30d4d23
@hyperbolic2346
updating comment to hopefully clarify the performance issue
aa41842
@hyperbolic2346
Updating from review comments
cf334cd
@hyperbolic2346
Moving explode out of reshape and some test cleanup
2fd6652
@hyperbolic2346
updating from review comments
d2584e6
@hyperbolic2346
adding explode.hpp to meta.yaml conda recipe
03701e7
@isVoid
Initial refactor
d963929
@isVoid
Merge branch 'explode-python-bindings' into 2975
7afdb5e
@isVoid
Merge branch 'mwilson/explode_outer' of github.com:hyperbolic2346/cud…
50e96c3 
…f into 2975
@isVoid
Passing tests
98cda02
@isVoid isVoid self-assigned this Mar 16, 2021
@github-actions github-actions bot added CMake CMake build issue conda Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Mar 16, 2021
@isVoid isVoid changed the title Adds explode python binding Add explode python binding Mar 16, 2021
@isVoid isVoid changed the title Add explode python binding Add explode API Mar 16, 2021
@isVoid isVoid added 2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change and removed CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels Mar 16, 2021
@isVoid isVoid mentioned this pull request Mar 16, 2021
Closed
@isVoid
Copy link
Contributor Author

isVoid commented Mar 16, 2021

Closing to clean up commit histories.

@isVoid isVoid closed this Mar 16, 2021
@isVoid isVoid reopened this Mar 16, 2021
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels Mar 16, 2021
@isVoid isVoid closed this Mar 16, 2021
@isVoid isVoid removed their assignment Mar 16, 2021
@isVoid isVoid deleted the 2975 branch March 17, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2 - In Progress Currently a work in progress CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isVoid @hyperbolic2346 @firestarman