Fix ORC issue with incorrect timestamp nanosecond values #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
vuule
requested review from
trxcllnt,
jrhemstad,
galipremsagar,
devavret and
kaatish
and removed request for
trxcllnt and
jrhemstad
galipremsagar
requested changes
Mar 12, 2021
galipremsagar
approved these changes
Mar 12, 2021
|
There's no significant perf impact on the writer, but the reader is up to 5% slower in some cases (timestamp columns only). I expected the writer to be more impacted, will look into why the reader is so much slower. |
devavret
approved these changes
Mar 12, 2021
ORC uses varint so integer encoding does not depend on the size. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7581 +/- ##
===============================================
+ Coverage 81.86% 82.38% +0.51%
===============================================
Files 101 101
Lines 16884 17340 +456
===============================================
+ Hits 13822 14285 +463
+ Misses 3062 3055 -7
Continue to review full report at Codecov.
|
|
@gpucibot merge |
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
Closes rapidsai#7355 Use 64 bit variables/buffers to handle nanosecond values since nanosecond encode can overflow a 32bit value in some cases. Removed the overloaded `intrle_minmax` function, using templated `numeric_limits` functions instead (the alternative was to add another overload). Performance impact evaluation pending, but this fix seems unavoidable regardless of the impact. Authors: - Vukasin Milovanovic (@vuule) Approvers: - GALI PREM SAGAR (@galipremsagar) - Devavret Makkar (@devavret) - Kumar Aatish (@kaatish) URL: rapidsai#7581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7355
Use 64 bit variables/buffers to handle nanosecond values since nanosecond encode can overflow a 32bit value in some cases.
Removed the overloaded
intrle_minmaxfunction, using templatednumeric_limitsfunctions instead (the alternative was to add another overload).Performance impact evaluation pending, but this fix seems unavoidable regardless of the impact.