Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Dask imports #7580

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix missing Dask imports #7580

merged 1 commit into from
Mar 12, 2021

Conversation

kkraus14
Copy link
Collaborator

dask/dask#7345 removed some imports that we were improperly using from a dask module. Fix the imports to properly target fsspec.

@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Mar 12, 2021
@kkraus14 kkraus14 requested a review from a team as a code owner March 12, 2021 17:40
@kkraus14 kkraus14 added the dask Dask issue label Mar 12, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 12, 2021
@jakirkham
Copy link
Member

@gpucibot merge

(this seems to only merge after CI has passed so should be fine)

@kkraus14 kkraus14 mentioned this pull request Mar 12, 2021
Merged
@kkraus14 kkraus14 mentioned this pull request Mar 12, 2021
Merged
@codecov
Copy link

codecov bot commented Mar 12, 2021 •
edited
Loading

Codecov Report

Merging #7580 (0dc2012) into branch-0.19 (7871e7a) will increase coverage by 0.51%.
The diff coverage is 92.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7580      +/-   ##
===============================================
+ Coverage        81.86%   82.38%   +0.51%     
===============================================
  Files              101      101              
  Lines            16884    17340     +456     
===============================================
+ Hits             13822    14285     +463     
+ Misses            3062     3055       -7
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 93.34% <ø> (+0.48%) ⬆️
python/cudf/cudf/core/column/column.py 87.80% <75.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.85% <85.71%> (-0.17%) ⬇️
python/cudf/cudf/core/frame.py 89.12% <89.47%> (+0.10%) ⬆️
python/cudf/cudf/core/column/decimal.py 93.33% <90.47%> (-1.54%) ⬇️
python/cudf/cudf/core/dataframe.py 90.58% <95.00%> (+0.11%) ⬆️
python/cudf/cudf/core/series.py 91.57% <95.55%> (+0.78%) ⬆️
python/cudf/cudf/core/column/string.py 86.76% <100.00%> (+0.26%) ⬆️
python/cudf/cudf/core/indexing.py 96.29% <100.00%> (+0.23%) ⬆️
python/dask_cudf/dask_cudf/io/orc.py 91.04% <100.00%> (+0.13%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aeb14e...0dc2012. Read the comment docs.

@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 365e649 into rapidsai:branch-0.19 Mar 12, 2021
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@hyperbolic2346
Fix missing Dask imports (rapidsai#7580)
66beb63 
dask/dask#7345 removed some imports that we were improperly using from a dask module. Fix the imports to properly target `fsspec`.

Authors:
  - Keith Kraus (@kkraus14)

Approvers:
  - @jakirkham
  - Ashwin Srinath (@shwina)

URL: rapidsai#7580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkraus14 @jakirkham @galipremsagar @shwina