Another fix for offsets_end() iterator in lists_column_view #7575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st fix was still not correct---that iterator should not be computed using the size of the offsets() child column, which is also the offsets of the original (non-sliced) column
ttnghia
changed the title
jrhemstad
approved these changes
Mar 11, 2021
|
You may want to run |
Hah, this is great. I just ran Probably it is a good practice to always call |
davidwendt
approved these changes
Mar 11, 2021
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7575 +/- ##
===============================================
+ Coverage 81.86% 82.40% +0.53%
===============================================
Files 101 101
Lines 16884 17342 +458
===============================================
+ Hits 13822 14290 +468
+ Misses 3062 3052 -10
Continue to review full report at Codecov.
|
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
…#7575) This is another fix for `offsets_end()` iterator in lists_column_view. The last fix (rapidsai#7551) was still not correct---that iterator should not be computed using the size of the `offsets()` child column, which is also the offsets of the original (non-sliced) column. Instead, it should be computed using the `size()` of the current column. Interestingly, my previous fix passed all the unit tests, since thrust does not throw anything (like access violation) when the input range is larger than the output range. Authors: - Nghia Truong (@ttnghia) Approvers: - Jake Hemstad (@jrhemstad) - David (@davidwendt) URL: rapidsai#7575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another fix for
offsets_end()iterator in lists_column_view. The last fix (#7551) was still not correct---that iterator should not be computed using the size of theoffsets()child column, which is also the offsets of the original (non-sliced) column. Instead, it should be computed using thesize()of the current column.Interestingly, my previous fix passed all the unit tests, since thrust does not throw anything (like access violation) when the input range is larger than the output range.