-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for strings::concatenate #7560
Add gbenchmark for strings::concatenate #7560
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7560 +/- ##
===============================================
+ Coverage 81.86% 82.44% +0.58%
===============================================
Files 101 101
Lines 16884 17369 +485
===============================================
+ Hits 13822 14320 +498
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
Why the API is |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about set_element_async usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake lgtm
@gpucibot merge |
Reference #5698
This creates a gbenchmark for
cudf::strings::concatenate
function. The benchmarks measures various sized rows as well as strings lengths. This PR also includes some changes tocombine.cu
for cleaning up the code and replacingdevice_vector
usages withdevice_uvector
.