Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gbenchmark for strings::concatenate #7560

Merged
merged 15 commits into from
Mar 18, 2021

Conversation

davidwendt
Copy link
Contributor

Reference #5698
This creates a gbenchmark for cudf::strings::concatenate function. The benchmarks measures various sized rows as well as strings lengths. This PR also includes some changes to combine.cu for cleaning up the code and replacing device_vector usages with device_uvector.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 10, 2021
@davidwendt davidwendt self-assigned this Mar 10, 2021
@github-actions github-actions bot added the CMake CMake build issue label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #7560 (597cbd9) into branch-0.19 (7871e7a) will increase coverage by 0.58%.
The diff coverage is 93.16%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7560      +/-   ##
===============================================
+ Coverage        81.86%   82.44%   +0.58%     
===============================================
  Files              101      101              
  Lines            16884    17369     +485     
===============================================
+ Hits             13822    14320     +498     
+ Misses            3062     3049      -13     
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 93.34% <ø> (+0.48%) ⬆️
python/cudf/cudf/core/series.py 91.65% <ø> (+0.86%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <ø> (+0.08%) ⬆️
python/cudf/cudf/utils/cudautils.py 52.94% <ø> (+2.55%) ⬆️
python/cudf/cudf/utils/dtypes.py 89.88% <ø> (+0.37%) ⬆️
python/dask_cudf/dask_cudf/io/orc.py 91.04% <ø> (+0.13%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.83% <87.50%> (-0.20%) ⬇️
python/cudf/cudf/core/frame.py 89.09% <89.47%> (+0.08%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <90.00%> (+0.10%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <90.32%> (-2.12%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4723051...597cbd9. Read the comment docs.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 15, 2021
@davidwendt davidwendt marked this pull request as ready for review March 15, 2021 16:40
@davidwendt davidwendt requested review from a team as code owners March 15, 2021 16:40
@ttnghia
Copy link
Contributor

ttnghia commented Mar 17, 2021

Why the API is concatenate but the file names are combine.hpp/cu? I would prefer consistency between the function and file names.

@davidwendt
Copy link
Contributor Author

Why the API is concatenate but the file names are combine.hpp/cu? I would prefer consistency between the function and file names.

The combine.hpp includes cudf::strings::concatenate and cudf::strings::join API declarations.

Copy link
Contributor

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about set_element_async usage.

cpp/src/strings/combine.cu Show resolved Hide resolved
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake lgtm

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f5a4214 into rapidsai:branch-0.19 Mar 18, 2021
@davidwendt davidwendt deleted the benchmark-strings-concat branch March 19, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants