Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no such file dlpack.h error when build libcudf #7549

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix no such file dlpack.h error when build libcudf #7549

merged 1 commit into from
Mar 10, 2021

Conversation

chenrui17
Copy link
Contributor

close #7548

@chenrui17 chenrui17 requested a review from a team as a code owner March 10, 2021 11:41
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Mar 10, 2021
@kkraus14
Copy link
Collaborator

ok to test

@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Mar 10, 2021
@kkraus14
Copy link
Collaborator

Thanks for the fix @chenrui17!

@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 10, 2021 •
edited
Loading

Codecov Report

Merging #7549 (5bd5e26) into branch-0.19 (7871e7a) will increase coverage by 0.07%.
The diff coverage is 89.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7549      +/-   ##
===============================================
+ Coverage        81.86%   81.93%   +0.07%     
===============================================
  Files              101      101              
  Lines            16884    16919      +35     
===============================================
+ Hits             13822    13863      +41     
+ Misses            3062     3056       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 90.46% <ø> (ø)
python/cudf/cudf/core/index.py 92.86% <ø> (ø)
python/cudf/cudf/core/column/column.py 87.70% <75.00%> (-0.06%) ⬇️
python/cudf/cudf/core/series.py 91.10% <90.00%> (+0.32%) ⬆️
python/cudf/cudf/core/column/decimal.py 93.33% <90.90%> (-1.54%) ⬇️
python/cudf/cudf/core/column/string.py 86.55% <100.00%> (+0.05%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/utils/utils.py 85.82% <0.00%> (+0.39%) ⬆️
python/cudf/cudf/core/dtypes.py 90.27% <0.00%> (+0.54%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4b5a6...5bd5e26. Read the comment docs.

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 35f3f70 into rapidsai:branch-0.19 Mar 10, 2021
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@chenrui17 @hyperbolic2346
Fix no such file dlpack.h error when build libcudf (rapidsai#7549)
e10fc49 
close rapidsai#7548

Authors:
  - @chenrui17

Approvers:
  - Keith Kraus (@kkraus14)

URL: rapidsai#7549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dlpack/dlpack.h: No such file or directory when build libcudf
3 participants
@chenrui17 @GPUtester @kkraus14