[REVIEW] Update missing docstring examples in python public APIs #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
kkraus14
approved these changes
Mar 10, 2021
kkraus14
added
5 - Ready to Merge
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7546 +/- ##
===============================================
+ Coverage 81.86% 81.90% +0.04%
===============================================
Files 101 101
Lines 16884 16900 +16
===============================================
+ Hits 13822 13842 +20
+ Misses 3062 3058 -4
Continue to review full report at Codecov.
|
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
Fully resolves: rapidsai#5290 This PR: - [x] Adds missing docstring examples in python public APIs. - [x] Adds some missing alias APIs. - [x] Fixes issue in `Series.take` where the index was not correctly being removed when `keep_index=False`. - [x] **Removes** `Series.values_to_string`, this API seems to be have been touched 4-years ago and since we have removed support for iterating over GPU objects thought it is best to remove this API altogether. Authors: - GALI PREM SAGAR (@galipremsagar) Approvers: - Keith Kraus (@kkraus14) URL: rapidsai#7546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully resolves: #5290
This PR:
Series.takewhere the index was not correctly being removed whenkeep_index=False.Series.values_to_string, this API seems to be have been touched 4-years ago and since we have removed support for iterating over GPU objects thought it is best to remove this API altogether.