Cudf build fix [skip ci] #7542
Closed
Cudf build fix [skip ci] #7542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
Co-authored-by: MithunR <[email protected]>
razajafri
added
3 - Ready for Review
nartal1
approved these changes
Mar 9, 2021
|
LGTM. |
|
build |
|
rerun tests |
gerashegalov
reviewed
Mar 9, 2021
| @@ -4005,7 +4005,7 @@ void testReplaceLeafNodeInList() { | |||
|
|
|||
| @Test | |||
| void testReplaceLeafNodeInListWithIllegal() { | |||
| assertThrows(IllegalArgumentException.class, () -> { | |||
| assertThrows(AssertionError.class, () -> { | |||
There was a problem hiding this comment.
can we also assert on the content of the expected exception message similar to https://stackoverflow.com/questions/40268446/junit-5-how-to-assert-an-exception-is-thrown.
There was a problem hiding this comment.
I have updated. Can you see the change?
There was a problem hiding this comment.
you may not have pushed yet @razajafri
|
closed in favor of #7542 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
This is a replacement of #7542 which was held up because the changes weren't being reflected on it. Authors: - Raza Jafri (@razajafri) Approvers: - Gera Shegalov (@gerashegalov) - Niranjan Artal (@nartal1) URL: #7544
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
This is a replacement of rapidsai#7542 which was held up because the changes weren't being reflected on it. Authors: - Raza Jafri (@razajafri) Approvers: - Gera Shegalov (@gerashegalov) - Niranjan Artal (@nartal1) URL: rapidsai#7544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken build as a result of an incomplete check-in.