[REVIEW] FIX Retry conda output location #7540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillon-cullinan
added
bug
raydouglass
approved these changes
Mar 9, 2021
ajschmidt8
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
👍
for reference, dropping a link to the gpuci_conda_retry source code where it defines and uses stderr for output instead of stdout
https://github.com/rapidsai/gpuci-tools/blob/main/tools/gpuci_conda_retry#L58-L60
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7540 +/- ##
===============================================
+ Coverage 81.88% 82.27% +0.39%
===============================================
Files 101 101
Lines 16900 17261 +361
===============================================
+ Hits 13838 14202 +364
+ Misses 3062 3059 -3
Continue to review full report at Codecov.
|
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
Reverts part of #7540 as it causes some unforeseen issues in uploading. Authors: - Dillon Cullinan (@dillon-cullinan) Approvers: - AJ Schmidt (@ajschmidt8) URL: #7552
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 11, 2021
Fixes the upload arguments introduced in this PR: #7540 Order matters! Authors: - Dillon Cullinan (@dillon-cullinan) Approvers: - Keith Kraus (@kkraus14) - AJ Schmidt (@ajschmidt8) URL: #7558
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
Utilize `gpuci_conda_retry` when grabbing file output locations. These commands can still result in `JSON Decode` errors that are typically reran in other conda build calls. `gpuci_conda_retry` outputs to `stderr` so that any failures will not be stored in the variable incorrectly. This PR also removes the upload progress being shown in branch builds. As time has passed, the upload progress has become much more spammy and becomes annoying in CI build outputs. Authors: - Dillon Cullinan (@dillon-cullinan) Approvers: - Ray Douglass (@raydouglass) - AJ Schmidt (@ajschmidt8) URL: rapidsai#7540
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
…#7552) Reverts part of rapidsai#7540 as it causes some unforeseen issues in uploading. Authors: - Dillon Cullinan (@dillon-cullinan) Approvers: - AJ Schmidt (@ajschmidt8) URL: rapidsai#7552
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
Fixes the upload arguments introduced in this PR: rapidsai#7540 Order matters! Authors: - Dillon Cullinan (@dillon-cullinan) Approvers: - Keith Kraus (@kkraus14) - AJ Schmidt (@ajschmidt8) URL: rapidsai#7558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize
gpuci_conda_retrywhen grabbing file output locations. These commands can still result inJSON Decodeerrors that are typically reran in other conda build calls.gpuci_conda_retryoutputs tostderrso that any failures will not be stored in the variable incorrectly.This PR also removes the upload progress being shown in branch builds. As time has passed, the upload progress has become much more spammy and becomes annoying in CI build outputs.