Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf::row_bit_count() support. #7534

Merged
merged 17 commits into from
Mar 30, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use make_empty_column() instead of make_fixed_width_column().
nvdbaranec committed Mar 29, 2021
commit b4ce7d1078711e15664fffd09ef47e169486a5a0
5 changes: 1 addition & 4 deletions cpp/src/transform/row_bit_count.cu
Original file line number Diff line number Diff line change
@@ -465,10 +465,7 @@ std::unique_ptr<column> row_bit_count(table_view const& t,
rmm::mr::device_memory_resource* mr)
{
// no rows
if (t.num_rows() <= 0) {
return cudf::make_fixed_width_column(
data_type{type_id::INT32}, 0, mask_state::UNALLOCATED, stream, mr);
}
if (t.num_rows() <= 0) { return cudf::make_empty_column(data_type{type_id::INT32}); }

// flatten the hierarchy and determine some information about it.
std::vector<cudf::column_view> cols;
2 changes: 1 addition & 1 deletion cpp/tests/transform/row_bit_count_test.cu
Original file line number Diff line number Diff line change
@@ -587,7 +587,7 @@ TEST_F(RowBitCount, EmptyTable)

{
auto strings = cudf::strings::detail::make_empty_strings_column(0);
auto ints = cudf::make_fixed_width_column(data_type{type_id::INT32}, 0);
auto ints = cudf::make_empty_column(data_type{type_id::INT32});
cudf::table_view empty({*strings, *ints});

auto result = cudf::row_bit_count(empty);