Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ARROW_STATIC_LIB because it conflicts with one in FindArrow.cmake #7518

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Rename ARROW_STATIC_LIB because it conflicts with one in FindArrow.cmake #7518

merged 2 commits into from
Mar 6, 2021

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Mar 5, 2021

Rename ARROW_STATIC_LIB because it conflicts with CMake variable in Arrow's FindArrow.cmake.

Here's the new way to statically link Arrow with libcudf:

cmake -D CUDF_USE_ARROW_STATIC=ON ..

@trxcllnt trxcllnt requested a review from a team as a code owner March 5, 2021 01:29
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Mar 5, 2021
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function tech debt labels Mar 5, 2021
kkraus14
kkraus14 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @trxcllnt

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Mar 5, 2021

The test failures seem unrelated to this change.

@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 5, 2021

rerun tests

@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 6, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Mar 6, 2021 •
edited
Loading

Codecov Report

Merging #7518 (729b300) into branch-0.19 (7871e7a) will increase coverage by 0.41%.
The diff coverage is 93.75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7518      +/-   ##
===============================================
+ Coverage        81.86%   82.27%   +0.41%     
===============================================
  Files              101      101              
  Lines            16884    17261     +377     
===============================================
+ Hits             13822    14202     +380     
+ Misses            3062     3059       -3
Impacted Files Coverage Δ
python/cudf/cudf/core/column/column.py 87.80% <75.00%> (+0.04%) ⬆️
python/cudf/cudf/core/column/decimal.py 95.83% <100.00%> (+0.96%) ⬆️
python/cudf/cudf/core/column/string.py 86.76% <100.00%> (+0.26%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd15b0...5c46272. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 6, 2021
@rapids-bot rapids-bot bot merged commit 3fefef6 into rapidsai:branch-0.19 Mar 6, 2021
@jlowe jlowe mentioned this pull request Mar 6, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Mar 6, 2021
@jlowe
Update JNI build to use CUDF_USE_ARROW_STATIC (#7526)
429e296 
This updates the Java build scripts and documentation to use the new CUDF_USE_ARROW_STATIC flag after the rename from ARROW_STATIC_LIB in #7518.

Authors:
  - Jason Lowe (@jlowe)

Approvers:
  - Alessandro Bellina (@abellina)
  - Keith Kraus (@kkraus14)

URL: #7526
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@trxcllnt @hyperbolic2346
Rename ARROW_STATIC_LIB because it conflicts with one in FindArrow.cm…
520d92c 
…ake (rapidsai#7518)

Rename `ARROW_STATIC_LIB` because it conflicts with CMake variable in Arrow's `FindArrow.cmake`.

Here's the new way to statically link Arrow with libcudf:
```
cmake -D CUDF_USE_ARROW_STATIC=ON ..
```

Authors:
  - Paul Taylor (@trxcllnt)

Approvers:
  - Keith Kraus (@kkraus14)

URL: rapidsai#7518
hyperbolic2346 pushed a commit to hyperbolic2346/cudf that referenced this pull request Mar 25, 2021
@jlowe @hyperbolic2346
Update JNI build to use CUDF_USE_ARROW_STATIC (rapidsai#7526)
b7d9d7d 
This updates the Java build scripts and documentation to use the new CUDF_USE_ARROW_STATIC flag after the rename from ARROW_STATIC_LIB in rapidsai#7518.

Authors:
  - Jason Lowe (@jlowe)

Approvers:
  - Alessandro Bellina (@abellina)
  - Keith Kraus (@kkraus14)

URL: rapidsai#7526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trxcllnt @kkraus14 @galipremsagar