Change device_vector to device_uvector in nvtext source files #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
trxcllnt
approved these changes
Mar 3, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7512 +/- ##
===============================================
+ Coverage 81.86% 82.29% +0.43%
===============================================
Files 101 101
Lines 16884 17264 +380
===============================================
+ Hits 13822 14208 +386
+ Misses 3062 3056 -6
Continue to review full report at Codecov.
|
harrism
requested changes
Mar 9, 2021
harrism
approved these changes
Mar 10, 2021
|
@gpucibot merge |
hyperbolic2346
pushed a commit
to hyperbolic2346/cudf
that referenced
this pull request
Mar 25, 2021
…ai#7512) Reference rapidsai#7287 This PR changes `cpp/src/text/*` source files to use `rmm::device_uvector` instead of `rmm:device_vector`. This allows keeping the memory operations on the provided kernel stream. Authors: - David (@davidwendt) Approvers: - Paul Taylor (@trxcllnt) - Mark Harris (@harrism) URL: rapidsai#7512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #7287
This PR changes
cpp/src/text/*source files to usermm::device_uvectorinstead ofrmm:device_vector. This allows keeping the memory operations on the provided kernel stream.