-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix off-by-one error in char-parallel string scalar replace #7502
Conversation
rerun tests |
I suspect the tests won't pass until #7507 is merged and this upmerges to get that fix. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7502 +/- ##
===============================================
+ Coverage 81.80% 82.26% +0.45%
===============================================
Files 101 101
Lines 16695 17245 +550
===============================================
+ Hits 13658 14186 +528
- Misses 3037 3059 +22
Continue to review full report at Codecov.
|
@gpucibot merge |
Fixes #7500.
The filter for target replacement positions crossing a string boundary had an off-by-one error. Target strings that were at the end of a string were incorrectly flagged as crossing a boundary.