Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one error in char-parallel string scalar replace #7502

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 3, 2021

Fixes #7500.

The filter for target replacement positions crossing a string boundary had an off-by-one error. Target strings that were at the end of a string were incorrectly flagged as crossing a boundary.

@jlowe jlowe added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) non-breaking Non-breaking change labels Mar 3, 2021
@jlowe jlowe requested a review from davidwendt March 3, 2021 15:34
@jlowe jlowe self-assigned this Mar 3, 2021
@jlowe jlowe requested a review from a team as a code owner March 3, 2021 15:34
@jlowe jlowe requested a review from trxcllnt March 3, 2021 15:34
@davidwendt
Copy link
Contributor

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Mar 3, 2021

I suspect the tests won't pass until #7507 is merged and this upmerges to get that fix.

@jlowe jlowe added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #7502 (dd94e10) into branch-0.19 (43b44e1) will increase coverage by 0.45%.
The diff coverage is 88.07%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7502      +/-   ##
===============================================
+ Coverage        81.80%   82.26%   +0.45%     
===============================================
  Files              101      101              
  Lines            16695    17245     +550     
===============================================
+ Hits             13658    14186     +528     
- Misses            3037     3059      +22     
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.57% <75.00%> (+0.33%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.74% <77.14%> (-0.49%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <78.57%> (+0.58%) ⬆️
python/dask_cudf/dask_cudf/core.py 71.67% <79.41%> (-2.60%) ⬇️
python/cudf/cudf/core/multiindex.py 82.90% <90.90%> (+0.73%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <93.33%> (+0.89%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <96.42%> (+0.43%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0c160...dd94e10. Read the comment docs.

@davidwendt
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 72438d8 into rapidsai:branch-0.19 Mar 4, 2021
@jlowe jlowe deleted the fix-string-replace branch September 10, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Function replace on strings gives wrong results
3 participants