Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JNI build after removal of libcudf sub-libraries [skip ci] #7486

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

jlowe
Copy link
Contributor

@jlowe jlowe commented Mar 2, 2021

Fixing the Java bindings build after the removal of the libcudf sub-libraries in #7107.

@jlowe jlowe added bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Mar 2, 2021
@jlowe jlowe requested a review from a team as a code owner March 2, 2021 19:35
@jlowe jlowe self-assigned this Mar 2, 2021
java/pom.xml Show resolved Hide resolved
@mythrocks
Copy link
Contributor

I'm 👍 on this. Kicking the tyres on this now.

@mythrocks
Copy link
Contributor

(Github does not allow me to add this comment because this section wasn't modified in the PR. :/)

We might need to modify the Arrow paths:

# Find static version of Arrow lib
find_library(ARROW_LIBRARY libarrow.a
  HINTS "$ENV{ARROW_ROOT}/lib"
        "$ENV{CONDA_PREFIX}/lib"
        "${CUDF_CPP_BUILD_DIR}/arrow/install/lib")

The build complains with: Arrow static libs not found. Was libcudf built with ARROW_STATIC_LIB=ON?, unless the last path is modified as follows:

find_library(ARROW_LIBRARY libarrow.a
  HINTS "$ENV{ARROW_ROOT}/lib"
        "$ENV{CONDA_PREFIX}/lib"
        "${CUDF_CPP_BUILD_DIR}/_deps/arrow-build/release")

The ARROW_INCLUDE path might need a similar change.

@jlowe
Copy link
Contributor Author

jlowe commented Mar 2, 2021

We might need to modify the Arrow paths

Thanks @mythrocks, this accidentally worked in my env because I had some old build artifacts around that it found. I updated the hints for the Arrow paths and verified with a clean build.

Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mythrocks
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 150df65 into rapidsai:branch-0.19 Mar 2, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants