-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JNI build after removal of libcudf sub-libraries [skip ci] #7486
Conversation
I'm 👍 on this. Kicking the tyres on this now. |
(Github does not allow me to add this comment because this section wasn't modified in the PR. :/) We might need to modify the Arrow paths: # Find static version of Arrow lib
find_library(ARROW_LIBRARY libarrow.a
HINTS "$ENV{ARROW_ROOT}/lib"
"$ENV{CONDA_PREFIX}/lib"
"${CUDF_CPP_BUILD_DIR}/arrow/install/lib") The build complains with: find_library(ARROW_LIBRARY libarrow.a
HINTS "$ENV{ARROW_ROOT}/lib"
"$ENV{CONDA_PREFIX}/lib"
"${CUDF_CPP_BUILD_DIR}/_deps/arrow-build/release") The |
Thanks @mythrocks, this accidentally worked in my env because I had some old build artifacts around that it found. I updated the hints for the Arrow paths and verified with a clean build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@gpucibot merge |
Fixing the Java bindings build after the removal of the libcudf sub-libraries in #7107.