Correctly compile benchmarks #7485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPM will force these variables to OFF and add them to the CMakeCache. This causes problems when you re-execute cmake in the same build directory as now they are set to OFF, and CUDF will not enable benchmarks/tests.
github-actions
bot
added
CMake
kkraus14
approved these changes
Mar 2, 2021
|
Does the same transitive propagation issue exist with |
Good question. I will update those just in case. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7485 +/- ##
===============================================
+ Coverage 81.85% 82.26% +0.40%
===============================================
Files 101 101
Lines 16883 17244 +361
===============================================
+ Hits 13819 14185 +366
+ Misses 3064 3059 -5
Continue to review full report at Codecov.
|
|
@gpucibot merge |
This was referenced Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #7107 introduced two subtle bugs that caused benchmarks to not build correctly.
benchmark_maintarget needs to be explicitly placed on the final executable link line as it injects object files, and that doesn't work via transitive propagation.BUILD_BENCHMARKSandBUILD_TESTINGare shared between RMM and CUDF. When CUDF builds RMM via CPM it will force cache these variables toOFF. This means that if a developer try to runcmake -DBUILD_BENCHMARKS=ON .any subsequent execution of justcmake .will cause CUDF to forget it should have kept benchmarks enabled.