Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine rolling window function tests #7480

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Combine rolling window function tests #7480

merged 3 commits into from
Mar 2, 2021

Conversation

mythrocks
Copy link
Contributor

@mythrocks mythrocks commented Mar 2, 2021 •
edited
Loading

The tests/ folder has several tests pertaining to *rolling_window() functionality:

  1. rolling/
  2. grouped_rolling/
  3. lead_lag/
  4. collect_list/

This commit consolidates all rolling_window-related tests into a single test directory.

Fixes #7455.
(This peripheral change was required for the consolidated rolling_test to link correctly.)

@mythrocks mythrocks requested review from a team as code owners March 2, 2021 00:32
@mythrocks mythrocks requested review from jrhemstad and vuule March 2, 2021 00:32
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Mar 2, 2021
@mythrocks
Copy link
Contributor Author

The contents of the tests have not been modified at all, except to remove CUDF_TEST_PROGRAM_MAIN().

The only stray modification here is to include/cudf/utilities/device_operators.cuh, to force internal linkage for max_string_sentinel. @karthikeyann, I wonder if you might be alright with that change.

@mythrocks mythrocks requested review from karthikeyann and removed request for jrhemstad March 2, 2021 00:35
@mythrocks mythrocks self-assigned this Mar 2, 2021
@vuule vuule added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 2, 2021
@mythrocks mythrocks added 3 - Ready for Review Ready for review by team code quality labels Mar 2, 2021
vuule
vuule reviewed Mar 2, 2021
View reviewed changes
cpp/include/cudf/detail/utilities/device_operators.cuh
@@ -92,7 +92,7 @@ struct DeviceCount {
* values. Also, this char pointer serves as valid device pointer of identity
* value for minimum operator on string values.
*/
__constant__ char max_string_sentinel[5]{"\xF7\xBF\xBF\xBF"};
static __constant__ char max_string_sentinel[5]{"\xF7\xBF\xBF\xBF"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaatish for visibility (wrt https://github.com/rapidsai/cudf/pull/7439/files#r583304683 convo).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harrism informs me that he discussed this bit with @karthikeyann, and that they are alright with this part. I have requested Karthik to examine this PR.

@codecov
Copy link

codecov bot commented Mar 2, 2021 •
edited
Loading

Codecov Report

Merging #7480 (8034f3f) into branch-0.19 (43b44e1) will increase coverage by 0.45%.
The diff coverage is 87.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7480      +/-   ##
===============================================
+ Coverage        81.80%   82.26%   +0.45%     
===============================================
  Files              101      101              
  Lines            16695    17244     +549     
===============================================
+ Hits             13658    14185     +527     
- Misses            3037     3059      +22
Impacted Files Coverage Δ
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/testing/testing.py 80.00% <57.14%> (-1.04%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.57% <75.00%> (+0.33%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.74% <77.14%> (-0.49%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.63% <78.57%> (+0.58%) ⬆️
python/dask_cudf/dask_cudf/core.py 71.67% <79.41%> (-2.60%) ⬇️
python/cudf/cudf/core/multiindex.py 82.90% <90.90%> (+0.73%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.53% <93.33%> (+0.89%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <96.42%> (+0.43%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61091a0...8034f3f. Read the comment docs.

@ttnghia ttnghia mentioned this pull request Mar 2, 2021
Closed
@ttnghia ttnghia linked an issue Mar 2, 2021 that may be closed by this pull request
[BUG] Multiple definition of `cudf::max_string_sentinel' #7455
Closed
@mythrocks
Copy link
Contributor Author

Thank you for the reviews, @karthikeyann, @vuule! I'll merge this now.

@mythrocks
Copy link
Contributor Author

Ah, shoot. Spotted the mistake on refresh. I'll request a cmake review before merging.

@harrism
Copy link
Member

harrism commented Mar 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c25b728 into rapidsai:branch-0.19 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism harrism approved these changes

Assignees

@mythrocks mythrocks

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Multiple definition of `cudf::max_string_sentinel'
4 participants
@mythrocks @harrism @karthikeyann @vuule