Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix __repr__ for categorical dtype #7476

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #7470

This PR:

  • Handles the dtype/categories representation correctly in a sliced series/Index.
  • Removes some NumPy deprecated code usages.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Mar 1, 2021
@galipremsagar galipremsagar requested review from kkraus14 and isVoid March 1, 2021 20:08
@galipremsagar galipremsagar self-assigned this Mar 1, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner March 1, 2021 20:08
python/cudf/cudf/core/frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/indexing.py Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_joining.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_joining.py Outdated Show resolved Hide resolved
@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 1, 2021

@gpucibot merge

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Mar 1, 2021
@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #7476 (30ca48a) into branch-0.19 (f79a841) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7476      +/-   ##
===============================================
+ Coverage        81.86%   82.26%   +0.39%     
===============================================
  Files              101      101              
  Lines            16883    17244     +361     
===============================================
+ Hits             13821    14185     +364     
+ Misses            3062     3059       -3     
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 93.34% <ø> (+0.48%) ⬆️
python/cudf/cudf/core/series.py 91.12% <ø> (+0.34%) ⬆️
python/cudf/cudf/core/dataframe.py 90.58% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/core/frame.py 89.12% <100.00%> (+0.10%) ⬆️
python/cudf/cudf/core/indexing.py 96.11% <100.00%> (+0.05%) ⬆️
python/cudf/cudf/core/scalar.py 87.43% <100.00%> (+0.33%) ⬆️
python/cudf/cudf/utils/utils.py 85.71% <100.00%> (+0.28%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79a841...30ca48a. Read the comment docs.

@kkraus14
Copy link
Collaborator

kkraus14 commented Mar 2, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit ed98f9a into rapidsai:branch-0.19 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] __repr__ for sliced categorical series is showing incorrect categories
2 participants