Remove dependence on managed memory for multimap test #7451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
added
libcudf
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7451 +/- ##
===============================================
+ Coverage 81.80% 82.26% +0.46%
===============================================
Files 101 101
Lines 16695 17072 +377
===============================================
+ Hits 13658 14045 +387
+ Misses 3037 3027 -10
Continue to review full report at Codecov.
|
| @@ -91,12 +96,3 @@ TYPED_TEST(MultimapTest, InitialState) | |||
| auto end = this->the_map->end(); | |||
| EXPECT_NE(begin, end); | |||
| } | |||
|
|
|||
| TYPED_TEST(MultimapTest, CheckUnusedValues) | |||
There was a problem hiding this comment.
why is this test removed?
There was a problem hiding this comment.
To remove the dependence on managed memory. It was accessing it from the host.
There was a problem hiding this comment.
Is there a way to add alternate test for this ?
There was a problem hiding this comment.
It's not necessary.
rgsl888prabhu
approved these changes
Mar 1, 2021
harrism
approved these changes
Mar 3, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes managed memory from the
HASH_MAP_TESTto allow the test to work on systems that don't support managed memory.