Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BUG: Exception when PYTHONOPTIMIZE=2 #7434

Merged
merged 5 commits into from
Feb 26, 2021
Merged

Fix BUG: Exception when PYTHONOPTIMIZE=2 #7434

merged 5 commits into from
Feb 26, 2021

Conversation

skirui-source
Copy link
Contributor

No description provided.

@skirui-source skirui-source added bug Something isn't working Python Affects Python cuDF API. labels Feb 24, 2021
@skirui-source skirui-source requested a review from a team as a code owner February 24, 2021 02:51
@skirui-source skirui-source changed the title Fix BUG Exception when PYTHONOPTIMIZE=2 Fix BUG: Exception when PYTHONOPTIMIZE=2 Feb 24, 2021
@skirui-source skirui-source added the 2 - In Progress Currently a work in progress label Feb 24, 2021
@skirui-source skirui-source added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021 •
edited
Loading

Codecov Report

Merging #7434 (905cd31) into branch-0.19 (43b44e1) will increase coverage by 0.43%.
The diff coverage is 94.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7434      +/-   ##
===============================================
+ Coverage        81.80%   82.24%   +0.43%     
===============================================
  Files              101      101              
  Lines            16695    17072     +377     
===============================================
+ Hits             13658    14041     +383     
+ Misses            3037     3031       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 89.35% <ø> (+0.09%) ⬆️
python/cudf/cudf/utils/docutils.py 97.36% <50.00%> (-2.64%) ⬇️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/dataframe.py 90.58% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80f9db...905cd31. Read the comment docs.

@skirui-source skirui-source added the breaking Breaking change label Feb 26, 2021
@shwina
Copy link
Contributor

shwina commented Feb 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6b579c7 into rapidsai:branch-0.19 Feb 26, 2021
@kkraus14 kkraus14 mentioned this pull request Feb 26, 2021
Closed
@skirui-source skirui-source linked an issue Mar 25, 2021 that may be closed by this pull request
[BUG] Exception when PYTHONOPTIMIZE=2 #4930
Closed
@skirui-source skirui-source self-assigned this Mar 26, 2021
@skirui-source skirui-source deleted the optimize branch May 6, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@isVoid isVoid Awaiting requested review from isVoid

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

Assignees

@skirui-source skirui-source

Labels
3 - Ready for Review Ready for review by team breaking Breaking change bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Exception when PYTHONOPTIMIZE=2
2 participants
@skirui-source @shwina