-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve string gather performance #7433
Conversation
Benchmark numbers.
After:
|
Very nice improvement. There's room for even further improvement by doing larger than 1B read/writes when possible as well, but that would be quite a bit more complex and I'm guessing the current speedup is satisfactory. |
I think this is something that @gaohao95 is planning on looking into in the near future. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7433 +/- ##
===============================================
+ Coverage 81.80% 82.24% +0.43%
===============================================
Files 101 101
Lines 16695 17069 +374
===============================================
+ Hits 13658 14039 +381
+ Misses 3037 3030 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Jason.
Great work. But since your work in mostly related to |
This test is organized by how the public API is organized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@gpucibot merge |
This improves string gather performance by using an algorithm with character-level parallelism. A string gather benchmark with varying row counts and row lengths has also been added.