-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inclusive scan safe for cases with leading nulls #7432
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
58b0185
Add a failing test case that passes a leading null to scan with skipn…
magnatelee c7f296e
Change the mask scan to make the failing test pass
magnatelee e19c6d9
Update cpp/tests/reductions/scan_tests.cpp
magnatelee 52d2672
Update cpp/tests/reductions/scan_tests.cpp
magnatelee c334cdd
Revert "Change the mask scan to make the failing test pass"
magnatelee 55a1cc9
Change set_null_mask to handle empty updates correctly
magnatelee 3a3eb12
Fix to make the style check happy
magnatelee 4d749a3
Make bitmask tests consistent with new contracts
magnatelee e07a8c0
Test for the new behavior
magnatelee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like these checks should be either merged or we should have more detailed error messages so that the separate checks are useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these assertions have a similar issue:
cudf/cpp/src/bitmask/null_mask.cu
Lines 387 to 388 in f30be67
cudf/cpp/src/bitmask/null_mask.cu
Lines 478 to 479 in f30be67
I didn't bother to see if there are more, but I feel improving such checks deserves a separate PR.