Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use user resource for a temporary allocation in sort_by_key #7431

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

magnatelee
Copy link
Contributor

This simple PR is to make sort_by_key not use the user resource for the temporarily allocated sorted_order.

@magnatelee magnatelee requested a review from a team as a code owner February 23, 2021 22:24
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 23, 2021
@magnatelee magnatelee requested a review from kkraus14 February 23, 2021 22:26
@vuule vuule added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #7431 (7c64062) into branch-0.19 (43b44e1) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7431      +/-   ##
===============================================
+ Coverage        81.80%   82.23%   +0.42%     
===============================================
  Files              101      101              
  Lines            16695    17060     +365     
===============================================
+ Hits             13658    14029     +371     
+ Misses            3037     3031       -6     
Impacted Files Coverage Δ
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/join/join.py 95.93% <0.00%> (+0.02%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2234554...bc9c084. Read the comment docs.

@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 24, 2021
@kkraus14
Copy link
Collaborator

rerun tests

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9c3a908 into rapidsai:branch-0.19 Feb 24, 2021
@magnatelee magnatelee deleted the resource-fix-sort branch February 26, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants