Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other cudf::strings::replace functions to current strings replace gbenchmark #7403

Merged

Conversation

davidwendt
Copy link
Contributor

Reference #5698

This builds off of PR #7369 to add cudf::strings::replace_slice and the multi-column version of cudf::strings::replace to the current gbenchmark that only measures scalar strings replace.

The current replace_scalar_benchmark.cpp is also renamed to replace_benchmark.cpp since it now handles more than the scalar replace.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2021
@davidwendt davidwendt requested review from a team as code owners February 17, 2021 19:10
@davidwendt davidwendt self-assigned this Feb 17, 2021
@github-actions github-actions bot added the CMake CMake build issue label Feb 17, 2021
@davidwendt davidwendt requested a review from jlowe February 17, 2021 19:10
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake approval

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@d180213). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7403   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      100           
  Lines                  ?    16971           
  Branches               ?        0           
==============================================
  Hits                   ?    13953           
  Misses                 ?     3018           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d180213...01ce44a. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1c835f5 into rapidsai:branch-0.19 Feb 19, 2021
@davidwendt davidwendt deleted the benchmark-strings-replace branch February 19, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants