Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Pass ccache variables to conda recipe & use Ninja in CI #7398

Merged
merged 2 commits into from
Feb 23, 2021
Merged

ENH Pass ccache variables to conda recipe & use Ninja in CI #7398

merged 2 commits into from
Feb 23, 2021

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Feb 17, 2021 •
edited
Loading

  • Add ccache env variables to conda recipe
  • Use Ninja in CI

@jjacobelli jjacobelli added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2021
@jjacobelli jjacobelli requested a review from a team as a code owner February 17, 2021 13:09
@github-actions github-actions bot added the conda label Feb 17, 2021
@jjacobelli jjacobelli changed the title ENH Build with Ninja & Pass ccache variables to conda recipe [WIP] ENH Build with Ninja & Pass ccache variables to conda recipe Feb 17, 2021
@jjacobelli jjacobelli changed the title [WIP] ENH Build with Ninja & Pass ccache variables to conda recipe [WIP] ENH Pass ccache variables to conda recipe Feb 17, 2021
@jjacobelli jjacobelli changed the title [WIP] ENH Pass ccache variables to conda recipe ENH Pass ccache variables to conda recipe Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.19@d180213). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.19    #7398   +/-   ##
==============================================
  Coverage               ?   82.21%           
==============================================
  Files                  ?      101           
  Lines                  ?    17057           
  Branches               ?        0           
==============================================
  Hits                   ?    14023           
  Misses                 ?     3034           
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d180213...e31ffbe. Read the comment docs.

@github-actions github-actions bot added the gpuCI label Feb 19, 2021
@jjacobelli jjacobelli changed the title ENH Pass ccache variables to conda recipe ENH Pass ccache variables to conda recipe & use Ninja in CI Feb 22, 2021
@jjacobelli
ENH Use Ninja to build in CI
e31ffbe 
Signed-off-by: Jordan Jacobelli <[email protected]>
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 640277e into rapidsai:branch-0.19 Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjacobelli @dillon-cullinan